Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/tz(ticdc): use correct ctx to get timezone (#8799) #8831

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8799

What problem does this PR solve?

Issue Number: ref #8798

What is changed and how it works?

  • Fix a bug that unescape the timezone value twice
  • Fix a bug we use the wrong ctx when we get the timezone.
  • Warning when users use time-zone="" in sink-uri.
  • Warning when users do not set the timezone in sink-uri

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

None

Do you need to update user documentation, design documentation or monitoring documentation?

None

Release note

Fix the bug that TiCDC always uses `UTC` when creating changefeed

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 21, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 26, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 26, 2023
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 736daec

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@Rustin170506
Copy link
Member

/test all

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/run-integration-test

1 similar comment
@Rustin170506
Copy link
Member

/run-integration-test

@Rustin170506
Copy link
Member

/retest

@Rustin170506
Copy link
Member

/test dm-integration-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

@hi-rustin: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test verify

Use /test all to run all jobs.

In response to this:

/test dm-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rustin170506
Copy link
Member

/run-dm-integration-test

@Rustin170506
Copy link
Member

/run-kafka-integration-test

@Rustin170506
Copy link
Member

/run-dm-integration-test

/run-kafka-integration-test

@Rustin170506
Copy link
Member

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 26c5d52 into pingcap:release-6.5 May 16, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants