Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler(ticdc): optimize owner memory allocation #8010

Merged
merged 7 commits into from
Jan 6, 2023
Merged

scheduler(ticdc): optimize owner memory allocation #8010

merged 7 commits into from
Jan 6, 2023

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7720

What is changed and how it works?

  • pkg/spanz(ticdc): increase btree degree to speed up Ascend
  • *(ticdc): cache []tablepb.Span
  • pkg/spanz(ticdc): do not let variables move to heap
  • scheduler(ticdc): do not let span move to heap

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Replicate 72k tables. Left master branch, right this PR.

  • alloc_objects are reduced from 46% to less than 1%
  • cpu are almost the same, from 3.44% to 3.19%

image

image

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 3, 2023
@overvenus overvenus added the area/ticdc Issues or PRs related to TiCDC. label Jan 3, 2023
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 3, 2023
@overvenus overvenus mentioned this pull request Jan 3, 2023
Closed
22 tasks
@overvenus overvenus changed the title pkg/spanz(ticdc): optimize owner memory allocation scheduler(ticdc): optimize owner memory allocation Jan 3, 2023
zhaoxinyu
zhaoxinyu reviewed Jan 4, 2023
View reviewed changes
3AceShowHand
3AceShowHand reviewed Jan 4, 2023
View reviewed changes
pkg/spanz/map.go
}
m.cache.coveredSpans = m.cache.coveredSpans[:0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add a new method named CleanCache to replace this 2 lines.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2023
@overvenus
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2023
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8279938

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2023
@zhaoxinyu
Copy link
Contributor

/run-engine-integration-test
/run-verify

@overvenus
Copy link
Member Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot merged commit 857e7cf into pingcap:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-chi-bot @zhaoxinyu @3AceShowHand