Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): support gcs scheme in redo log #7993

Merged
merged 6 commits into from
Jan 4, 2023
Merged

redo(ticdc): support gcs scheme in redo log #7993

merged 6 commits into from
Jan 4, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Dec 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7987, close #6335

What is changed and how it works?

  1. Extract external_storage util to manage external storage creation.
  2. Extract pkg/redo and add support to gcs and azure scheme.
  3. Add ConsistentConfig.ValidateAndAdjust.
  4. Refactor code and test structure, and remove some useless logic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
  • After this pr, consistent.flush-interval should not less than 2000. And we need update the office document.
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Fix the issue of gcs and azure scheme are not supported in the redo log`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 28, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the redo_support_gcs branch 2 times, most recently from 2f95fc9 to 995178d Compare December 29, 2022 06:39
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 29, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the redo_support_gcs branch 4 times, most recently from 8ec390c to 787e913 Compare December 29, 2022 15:35
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Dec 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 3, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review January 3, 2023 07:57
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the redo_support_gcs branch 3 times, most recently from ea86abc to b5873fc Compare January 3, 2023 14:42
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 4, 2023
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66a5bf4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2023
@amyangfei
Copy link
Contributor

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 4, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-test
/run-integration-test

@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit dacb992 into pingcap:master Jan 4, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 4, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8016.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 4, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#7993
2b09ee0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 4, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8017.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 4, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#7993
772140d 
Signed-off-by: ti-chi-bot <[email protected]>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 4, 2023
@CharlesCheung96
redo(ticdc): support gcs scheme in redo log (pingcap#7993)
7cae4c9 
close pingcap#6335, close pingcap#7987
ti-chi-bot added a commit that referenced this pull request Jan 4, 2023
@ti-chi-bot
redo(ticdc): support gcs scheme in redo log (#7993) (#8017)
3808d97 
close #6335, close #7987
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 4, 2023
@CharlesCheung96
redo(ticdc): support gcs scheme in redo log (pingcap#7993)
baff0a0 
close pingcap#6335, close pingcap#7987
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 4, 2023
@CharlesCheung96
redo(ticdc): support gcs scheme in redo log (pingcap#7993)
5d12faf 
close pingcap#6335, close pingcap#7987
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 5, 2023
@CharlesCheung96
redo(ticdc): support gcs scheme in redo log (pingcap#7993)
9d46704 
close pingcap#6335, close pingcap#7987
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 5, 2023
ti-chi-bot added a commit that referenced this pull request Jan 5, 2023
@ti-chi-bot
redo(ticdc): support gcs scheme in redo log (#7993) (#8016)
f69c799 
close #6335, close #7987
overvenus
overvenus reviewed Jan 6, 2023
View reviewed changes
pkg/config/consistent.go

if c.FlushIntervalInMs < MinFlushIntervalInMs {
return cerror.ErrInvalidReplicaConfig.FastGenByArgs(
fmt.Sprintf("The consistent.flush-interval:%d must be equal or greater than %d",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a breaking change, also the official document recommends 500-2000.

https://github.com/pingcap/docs/blob/e59c1072982e68ecd479a9619068bb658c275ef2/ticdc/ticdc-sink-to-mysql.md?plain=1#L108-L109

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a detailed describetion of compatibility changes in pr body and will fix official document in this pr.

@overvenus overvenus mentioned this pull request Jan 6, 2023
Closed
@CharlesCheung96 CharlesCheung96 mentioned this pull request Jan 9, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus left review comments

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support gcs scheme in redo log redo log: storage permission pre-check is need
5 participants
@CharlesCheung96 @ti-chi-bot @amyangfei @overvenus @nongfushanquan