Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dm): add foreign key test #7902

Merged
merged 6 commits into from
Dec 20, 2022
Merged

test(dm): add foreign key test #7902

merged 6 commits into from
Dec 20, 2022

Conversation

liumengya94
Copy link
Contributor

@liumengya94 liumengya94 commented Dec 13, 2022 •
edited by lance6716
Loading

What problem does this PR solve?

Issue Number: ref #7598

What is changed and how it works?

  • append foreign_key_checks=0 in dsn if user didn't configure
  • add a test to check the inconsistency of upstream and downstream data when tidb set foreign_key_checks=0

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

use foreign_key_checks=0 for incremental replication phase, which may cause data inconsistency

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2022
@liumengya94
Copy link
Contributor Author

/run-dm-integration-test

@liumengya94
Copy link
Contributor Author

/cc @lance6716

@ti-chi-bot ti-chi-bot requested a review from lance6716 December 14, 2022 01:31
@lance6716 lance6716 changed the title dm: add foreign key test test(dm): add foreign key test Dec 14, 2022
@liumengya94
Copy link
Contributor Author

/run-all-tests

lance6716
lance6716 reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm. please update the release note part of PR description

dm/tests/foreign_key/run.sh Outdated
Comment on lines 32 to 34

# close foreign_key_checks
run_sql_tidb "set @@foreign_key_checks=0;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# close foreign_key_checks
run_sql_tidb "set @@foreign_key_checks=0;"

no effects to change a session variable

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 15, 2022
@liumengya94
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 19, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bca57d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@ti-chi-bot
Copy link
Member

@liumengya94: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 45ee743 into pingcap:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liumengya94 @ti-chi-bot @lance6716 @D3Hunter