Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg(ticdc): merge package regionspan and spanz #7880

Merged
merged 21 commits into from
Dec 21, 2022
Merged

pkg(ticdc): merge package regionspan and spanz #7880

merged 21 commits into from
Dec 21, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7720

What is changed and how it works?

This is a clean up PR, for now there are two span in TiCDC code base. We should unify Span usage to avoid confusing.

  • Remove regionspan.Span
  • Replace regionspan.ComparableSpan to tablepb.Span.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 12, 2022
@overvenus overvenus added the area/ticdc Issues or PRs related to TiCDC. label Dec 12, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 12, 2022
@overvenus overvenus mentioned this pull request Dec 12, 2022
Closed
22 tasks
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
make fmt
923fb67 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
fix tests
d0bb778 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
Copy link
Member Author

/run-all-tests pd=release-6.5

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 16, 2022
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 05aa437

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2022
@overvenus
Copy link
Member Author

/run-engine-integration-test

@overvenus
Copy link
Member Author

/run-engine-integration-test

1 similar comment
@overvenus
Copy link
Member Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot merged commit 2e9542a into pingcap:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-chi-bot @amyangfei @3AceShowHand