Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema (ticdc): support exchange partition #7118

Merged
merged 20 commits into from
Sep 21, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Sep 19, 2022

What problem does this PR solve?

Issue Number: close #6322 #639

What is changed and how it works?

It is well commented in the code, plz take a look at it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Make CDC support exchange partition ddl.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 19, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2022
@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2022
@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-integration-test tidb=master tikv=master

@asddongmen
Copy link
Contributor Author

/run-integration-test tidb=master tikv=master

1 similar comment
@asddongmen
Copy link
Contributor Author

/run-integration-test tidb=master tikv=master

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a3b782

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@asddongmen
Copy link
Contributor Author

/run-integration-test tidb=master tikv=master

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests tidb=master tikv=master

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e5ca851

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@asddongmen
Copy link
Contributor Author

/run-dm-integration-tess

@asddongmen asddongmen closed this Sep 21, 2022
@asddongmen asddongmen reopened this Sep 21, 2022
@asddongmen
Copy link
Contributor Author

/run-dm-integration-test

@nongfushanquan
Copy link
Contributor

/run-engine-integration-test

@ti-chi-bot
Copy link
Member

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

Codecov Report

Merging #7118 (b6afb5b) into master (0e3ca7c) will decrease coverage by 0.2300%.
The diff coverage is 68.5049%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.1905% <71.6287%> (+0.0394%) ⬆️
dm 51.8978% <64.1891%> (+0.0706%) ⬆️
engine 60.5932% <56.7010%> (-2.0539%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7118        +/-   ##
================================================
- Coverage   59.8212%   59.5911%   -0.2301%     
================================================
  Files           792        795         +3     
  Lines         90727      91532       +805     
================================================
+ Hits          54274      54545       +271     
- Misses        31693      32204       +511     
- Partials       4760       4783        +23     

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7161.

ti-chi-bot added a commit that referenced this pull request Sep 22, 2022
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.3 Should cherry pick this PR to release-6.3 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it reasonable to discard this DDL "ALTER TABLE ...EXCHANGE PARTITION " ?
5 participants