Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions(dm): fix default MySQL image changed to CentOS based #6500

Merged
merged 3 commits into from
Jul 28, 2022
Merged

actions(dm): fix default MySQL image changed to CentOS based #6500

merged 3 commits into from
Jul 28, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

as title

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 28, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Jul 28, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2022
@lance6716 lance6716 requested a review from GMHDBJD July 28, 2022 04:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #6500 (7ab4ed5) into master (f0e21a6) will increase coverage by 0.0294%.
The diff coverage is 78.1170%.

Flag Coverage Δ
cdc 66.1167% <72.0306%> (+0.0397%) ⬆️
dm 52.0450% <ø> (-0.0278%) ⬇️
engine 64.1676% <90.1515%> (+0.0666%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6500        +/-   ##
================================================
+ Coverage   59.4618%   59.4913%   +0.0294%     
================================================
  Files           762        765         +3     
  Lines         87377      87606       +229     
================================================
+ Hits          51956      52118       +162     
- Misses        30815      30872        +57     
- Partials       4606       4616        +10

GMHDBJD
GMHDBJD approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ab4ed5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 1a3b127 into pingcap:master Jul 28, 2022
@lance6716 lance6716 deleted the fix-actions-2 branch November 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-chi-bot @codecov-commenter @amyangfei @GMHDBJD