Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter(ticdc): Move filter from sink to mounter and owner/schema. #5936

Merged
merged 21 commits into from
Jun 28, 2022
Merged

filter(ticdc): Move filter from sink to mounter and owner/schema. #5936

merged 21 commits into from
Jun 28, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jun 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5937

What is changed and how it works?

Move filter from sink to mounter and owner/schema, they are responsible for parsing dml and ddl events respectively.
It is more reasonable to filter dml/ddl events in these two places rather than in sink.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 20, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 20, 2022
@asddongmen asddongmen added area/ticdc Issues or PRs related to TiCDC. component/mounter Mounter component labels Jun 20, 2022
@asddongmen
Copy link
Contributor Author

I will fix the filed test cases ASAP.

@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-verify

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-leak-tests

@asddongmen asddongmen added status/ptal Could you please take a look? labels Jun 22, 2022
Rustin170506
Rustin170506 requested changes Jun 23, 2022
View reviewed changes
cdc/model/sink.go Outdated Show resolved Hide resolved
cdc/owner/changefeed.go Outdated Show resolved Hide resolved
zhaoxinyu
zhaoxinyu reviewed Jun 28, 2022
View reviewed changes
pkg/filter/filter.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@ti-chi-bot
Copy link
Member

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506 Rustin170506 removed the status/ptal Could you please take a look? label Jun 28, 2022
@Rustin170506
Copy link
Member

/merge cancel

@asddongmen Please fix the lint.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 02915cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@asddongmen
Copy link
Contributor Author

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit 8e8fddb into pingcap:master Jun 28, 2022
@asddongmen asddongmen mentioned this pull request Jul 8, 2022
Closed
5 tasks
@asddongmen asddongmen deleted the move_filter_to_mounter branch July 21, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/mounter Mounter component release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move filter from sink to mounter and changefeed.
5 participants
@asddongmen @ti-chi-bot @Rustin170506 @zhaoxinyu @CharlesCheung96