Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dm): try fix upstream switch CI #5337

Merged
merged 5 commits into from
May 6, 2022
Merged

test(dm): try fix upstream switch CI #5337

merged 5 commits into from
May 6, 2022

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2022
@lance6716
Copy link
Contributor Author

https://github.com/pingcap/tiflow/actions/runs/2279221315

@lance6716 lance6716 added area/dm Issues or PRs related to DM. require-LGT1 Indicates that the PR requires an LGTM. labels May 6, 2022
lichunzhu
lichunzhu approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2022
@lance6716
address comment
18f1c59 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 18f1c59

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed status/can-merge Indicates a PR has been approved by a committer. labels May 6, 2022
@lance6716
Copy link
Contributor Author

https://github.com/pingcap/tiflow/actions/runs/2279361716

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #5337 (bafd5aa) into master (687e248) will increase coverage by 0.0448%.
The diff coverage is 54.3836%.

Flag Coverage Δ
cdc 61.0886% <54.3836%> (+0.4900%) ⬆️
dm 52.2604% <ø> (-0.2091%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5337        +/-   ##
================================================
+ Coverage   56.1240%   56.1688%   +0.0448%     
================================================
  Files           522        527         +5     
  Lines         65325      69300      +3975     
================================================
+ Hits          36663      38925      +2262     
- Misses        25094      26658      +1564     
- Partials       3568       3717       +149

@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bafd5aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2022
@ti-chi-bot ti-chi-bot merged commit fbbf359 into pingcap:master May 6, 2022
@lance6716 lance6716 deleted the fix-upstream-switch branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @codecov-commenter @lichunzhu