Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay(dm): send one heartbeat for successive skipped GTID (#5070) #5092

Merged
merged 8 commits into from
Apr 7, 2022
Merged

relay(dm): send one heartbeat for successive skipped GTID (#5070) #5092

merged 8 commits into from
Apr 7, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5070

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: ref #5063

What is changed and how it works?

see #5063 (comment)

Check List

Tests

  • Integration test
  • Unit tests

Related changes

  • Need to cherry-pick to the release branch

Release note 

send one heartbeat for successive skipped GTID when enable relay log

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Apr 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Apr 1, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2022
@lance6716
resolve confict
d2f5fb7 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 2, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9b8fde4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 7, 2022
@lance6716
fix ut
3144cae 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
lance6716 added 2 commits April 7, 2022 13:11
@lance6716
fix CI
15eec5e 
Signed-off-by: lance6716 <[email protected]>
@lance6716
fix CI
2340851 
Signed-off-by: lance6716 <[email protected]>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@0e0c808). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #5092   +/-   ##
================================================
  Coverage               ?   55.6302%           
================================================
  Files                  ?        222           
  Lines                  ?      23791           
  Branches               ?          0           
================================================
  Hits                   ?      13235           
  Misses                 ?       9228           
  Partials               ?       1328

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 2340851

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@lance6716
Copy link
Contributor

/run-dm-integration-test

@lance6716
Copy link
Contributor

/hold

checking newly added integration tests

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@lance6716
fix CI
36500ff 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@lance6716
Copy link
Contributor

/unhold

/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 36500ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@lance6716
Copy link
Contributor

/run-unit-test

@lance6716
Copy link
Contributor

/run-dm-integration-test
/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test

@ti-chi-bot ti-chi-bot merged commit 2605a84 into pingcap:release-5.3 Apr 7, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lance6716 lance6716

Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @lance6716 @codecov-commenter @VelocityLight @heibaijian