Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema(cdc): fix DML construct error caused by 'rename tables' DDL #5068

Merged
merged 9 commits into from
Mar 30, 2022
Merged

schema(cdc): fix DML construct error caused by 'rename tables' DDL #5068

merged 9 commits into from
Mar 30, 2022

Conversation

maxshuang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5059

What is changed and how it works?

Don't return directly for 'rename tables' DDL logic in schema_storge.go:handleDDL,
ref:

tiflow/cdc/entry/schema_storage.go

Line 606 in fffe5a1

return s.renameTables(job)

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

fix DML construct error issue caused by `rename tables` DDL.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2022
@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-leak-test

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

@overvenus overvenus added component/ddl DDL component. area/ticdc Issues or PRs related to TiCDC. labels Mar 30, 2022
@ti-chi-bot
Copy link
Member

@hicqu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

overvenus
overvenus approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

cdc/processor/processor.go Outdated Show resolved Hide resolved
tests/integration_tests/rename_tables/data/test.sql Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@overvenus: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/run-verify

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-verify

@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0ae4331

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2022
@3AceShowHand
Copy link
Contributor

/merge

@3AceShowHand 3AceShowHand changed the title fix(schema): fix DML construct error caused by 'rename tables' DDL cdc/schema: fix DML construct error caused by 'rename tables' DDL Mar 30, 2022
@3AceShowHand 3AceShowHand changed the title cdc/schema: fix DML construct error caused by 'rename tables' DDL schema(cdc): fix DML construct error caused by 'rename tables' DDL Mar 30, 2022
@overvenus
Copy link
Member

/run-leak-test

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-leak-test

@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

1 similar comment
@maxshuang
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@maxshuang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus overvenus merged commit a9d5d5a into pingcap:master Mar 30, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 30, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#5068
956cdd6 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 30, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5079.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 30, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5080.

overvenus added a commit that referenced this pull request Mar 31, 2022
@ti-chi-bot @overvenus
schema(cdc): fix DML construct error caused by 'rename tables' DDL (#…
2f363f6 
…5068) (#5080)

* fix(schema): fix DML construct error caused by 'rename tables' DDL

close  #5059

Co-authored-by: maxshuang <[email protected]>
Co-authored-by: Neil Shen <[email protected]>
maxshuang pushed a commit that referenced this pull request Apr 27, 2022
@ti-chi-bot
schema(cdc): fix DML construct error caused by 'rename tables' DDL (#…
bd9849b 
…5068) (#5079)

* This is an automated cherry-pick of #5068

Signed-off-by: ti-chi-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@hicqu hicqu hicqu approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/ddl DDL component. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DML construct error and changefeed stop caused by 'rename tables'
5 participants
@maxshuang @ti-chi-bot @overvenus @3AceShowHand @hicqu