Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM(syncer): fix lost lost dml under special sharding ddls (#5006) #5026

Merged
merged 2 commits into from
Apr 6, 2022
Merged

DM(syncer): fix lost lost dml under special sharding ddls (#5006) #5026

merged 2 commits into from
Apr 6, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5006

What problem does this PR solve?

Issue Number: close #5002

What is changed and how it works?

Change the check method of whether sync dml to be active ddl >= dml.

Check List

Tests

  • Integration test

Release note 

None

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2022
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Mar 25, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2022
@lance6716
Copy link
Contributor

@WizardXiao please resolve confict

@WizardXiao
Copy link
Contributor

@WizardXiao please resolve confict

ok

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 2, 2022
@WizardXiao
Copy link
Contributor

/run-all-tests

@WizardXiao
Copy link
Contributor

/run-verify-ci

@WizardXiao
Copy link
Contributor

The local environment is not replicated.
/run-verify-ci

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 6, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: fa3ca75

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2022
@lance6716
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 0e0c808 into pingcap:release-5.3 Apr 6, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WizardXiao WizardXiao

Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @lance6716 @WizardXiao @VelocityLight @heibaijian