Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: fix task status not deleted when capture is crashed #488

Merged
merged 1 commit into from
Apr 26, 2020
Merged

owner: fix task status not deleted when capture is crashed #488

merged 1 commit into from
Apr 26, 2020

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Apr 24, 2020 •
edited
Loading

What problem does this PR solve?

Fix #485

NOTE: there still exists another problem, with the following time sequence. I will fix this problem in another PR

capture-1 crashes -> 
  owner doesn't finish `removeCapture` before it is evicted ->
  another capture becomes owner, but the new owner doesn't aware of the existence of capture-1

What is changed and how it works?

  • loadChangeFeeds once before watchCapture
  • separate balanceTables from loadChangeFeeds

Check List

Tests

  • Unit test
  • Integration test

@amyangfei amyangfei added the subject/ha Denotes an issue or pull request is related to high availability. label Apr 24, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Apr 24, 2020
@amyangfei amyangfei requested a review from zier-one April 24, 2020 09:06
zier-one
zier-one approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT1 and removed status/ptal Could you please take a look? labels Apr 26, 2020
@amyangfei amyangfei merged commit df9667f into pingcap:master Apr 26, 2020
@amyangfei amyangfei deleted the fix-remove-capture branch April 26, 2020 03:56
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
owner: fix task status not deleted when capture is crashed (pingcap#488)
2c26468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
subject/ha Denotes an issue or pull request is related to high availability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task status is not deleted when a capture is suicided
2 participants
@amyangfei @zier-one