Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit_test: fix concurrency test cause etcd race #4830

Merged
merged 6 commits into from
Mar 10, 2022
Merged

unit_test: fix concurrency test cause etcd race #4830

merged 6 commits into from
Mar 10, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Mar 9, 2022

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

  • execute test serially

Check List

Tests

  • Unit test
`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2022
@GMHDBJD GMHDBJD added status/ptal Could you please take a look? component/test Unit tests and integration tests component. area/dm Issues or PRs related to DM. labels Mar 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2022
@GMHDBJD GMHDBJD added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 9, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7700e0a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 9, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@D3Hunter
Copy link
Contributor

still has this error

https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/ut-check/runs/4716/nodes/45/steps/49/log/?start=0

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

/run-all-tests

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 10, 2022

@lance6716 @D3Hunter dm_ut passed, PTAL

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #4830 (ebb9f63) into master (9607554) will increase coverage by 0.2151%.
The diff coverage is 53.4579%.

Flag Coverage Δ
cdc 59.9425% <53.4579%> (+0.0203%) ⬆️
dm 52.5024% <ø> (+0.4735%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4830        +/-   ##
================================================
+ Coverage   55.6402%   55.8554%   +0.2151%     
================================================
  Files           494        522        +28     
  Lines         61283      64923      +3640     
================================================
+ Hits          34098      36263      +2165     
- Misses        23750      25129      +1379     
- Partials       3435       3531        +96

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebb9f63

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2022
@ti-chi-bot ti-chi-bot merged commit 8135e92 into pingcap:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @ti-chi-bot @D3Hunter @codecov-commenter @lance6716