Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capture(cdc): add owner info to help debug etcd_worker, and also some in sink. #4325

Merged
merged 47 commits into from
Jan 17, 2022
Merged

capture(cdc): add owner info to help debug etcd_worker, and also some in sink. #4325

merged 47 commits into from
Jan 17, 2022

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Jan 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4331

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2022
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 14, 2022
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-dm-compatibility-test
/run-dm-integration-test
/run-integration-test
/run-kafka-integration-test

@3AceShowHand 3AceShowHand self-assigned this Jan 14, 2022
@3AceShowHand 3AceShowHand changed the title capture(cdc): add owner info to help debug etcd_worker. capture(cdc): add owner info to help debug etcd_worker, and also some in sink. Jan 14, 2022
@3AceShowHand 3AceShowHand changed the title capture(cdc): add owner info to help debug etcd_worker, and also some in sink. [DNM]capture(cdc): add owner info to help debug etcd_worker, and also some in sink. Jan 14, 2022
@3AceShowHand 3AceShowHand added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2022
asddongmen
asddongmen requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@asddongmen asddongmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@3AceShowHand
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 25b134d into pingcap:master Jan 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 17, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4325
527d09d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4363.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 17, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4325
0081ec1 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4364.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 17, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4325
e92dbb5 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4365.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4366.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 17, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4325
ac4aa21 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 17, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4325
30833d5 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4367.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 17, 2022
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#4325
17f6742 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4368.

buchuitoudegou pushed a commit to buchuitoudegou/tiflow that referenced this pull request Jan 18, 2022
@3AceShowHand @buchuitoudegou
capture(cdc): add owner info to help debug etcd_worker, and also some…
c5c995f 
… in sink. (pingcap#4325)

close pingcap#4331
buchuitoudegou pushed a commit to buchuitoudegou/tiflow that referenced this pull request Jan 18, 2022
@3AceShowHand @buchuitoudegou
capture(cdc): add owner info to help debug etcd_worker, and also some…
d5d5ab9 
… in sink. (pingcap#4325)

close pingcap#4331
buchuitoudegou pushed a commit to buchuitoudegou/tiflow that referenced this pull request Jan 19, 2022
@3AceShowHand @buchuitoudegou
capture(cdc): add owner info to help debug etcd_worker, and also some…
5c83e20 
… in sink. (pingcap#4325)

close pingcap#4331
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
@3AceShowHand @zhaoxinyu
capture(cdc): add owner info to help debug etcd_worker, and also some…
665ec4e 
… in sink. (pingcap#4325)

close pingcap#4331
3AceShowHand added a commit that referenced this pull request Jan 28, 2022
@ti-chi-bot @3AceShowHand
capture(cdc): add owner info to help debug etcd_worker, and also some…
8edcadd 
… in sink. (#4325) (#4367)

* This is an automated cherry-pick of #4325

Signed-off-by: ti-chi-bot <[email protected]>

* resolve conflict.

* resolve conflict.

* resolve conflict.

* fix client_test.

* fix conflicts.

Co-authored-by: Ling Jin <[email protected]>
Co-authored-by: 3AceShowHand <[email protected]>
ti-chi-bot added a commit that referenced this pull request Feb 18, 2022
@ti-chi-bot
capture(cdc): add owner info to help debug etcd_worker, and also some…
0f8e1b4 
… in sink. (#4325) (#4365)

close #4331
ti-chi-bot added a commit that referenced this pull request Feb 18, 2022
@ti-chi-bot
capture(cdc): add owner info to help debug etcd_worker, and also some…
26c222d 
… in sink. (#4325) (#4368)

close #4331
ti-chi-bot added a commit that referenced this pull request Feb 18, 2022
@ti-chi-bot
capture(cdc): add owner info to help debug etcd_worker, and also some…
21d6d6f 
… in sink. (#4325) (#4366)

close #4331
ti-chi-bot added a commit that referenced this pull request Feb 18, 2022
@ti-chi-bot
capture(cdc): add owner info to help debug etcd_worker, and also some…
80d5c6f 
… in sink. (#4325) (#4364)

close #4331
ti-chi-bot added a commit that referenced this pull request Feb 21, 2022
@ti-chi-bot
capture(cdc): add owner info to help debug etcd_worker, and also some…
2490dc5 
… in sink. (#4325) (#4363)

close #4331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@asddongmen asddongmen asddongmen approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

Assignees

@3AceShowHand 3AceShowHand

Labels
component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdc add more logs to help debug etcd_worker
6 participants
@3AceShowHand @ti-chi-bot @codecov-commenter @amyangfei @overvenus @asddongmen