sink/kafka: batch send messages #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
|
/run-kafka-tests |
|
/run-kafka-tests |
|
/run-kafka-tests |
1 similar comment
|
/run-kafka-tests |
5kbpers
force-pushed
the
batch-kafka
branch
2 times, most recently
from
6dc3b0a to
2cc6079
Compare
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
|
/run-kafka-tests |
Signed-off-by: 5kbpers <[email protected]>
|
/run-kafka-tests |
5kbpers
force-pushed
the
batch-kafka
branch
2 times, most recently
from
deff569 to
d6f4659
Compare
Signed-off-by: 5kbpers <[email protected]>
|
/run-kafka-tests |
Signed-off-by: 5kbpers <[email protected]>
|
/run-kafka-tests |
|
/run-kafka-tests |
|
/run-kafka-tests |
|
/run-kafka-tests |
|
/run-kafka-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
===========================================
Coverage 30.0229% 30.0229%
===========================================
Files 58 58
Lines 5669 5669
===========================================
Hits 1702 1702
Misses 3852 3852
Partials 115 115 |
|
/run-all-tests |
|
/run-kafka-tests |
|
/run-kafka-tests |
|
/run-integration-tests |
amyangfei
reviewed
Apr 9, 2020
cdc/sink/mqProducer/kafka.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (k *kafkaSaramaProducer) BroadcastMessage(ctx context.Context, key *model.MqMessageKey, value *model.MqMessageDDL) error { |
|
/run-all-tests |
5kbpers
added a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
Signed-off-by: 5kbpers <[email protected]> Co-authored-by: leoppro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers [email protected]
What problem does this PR solve?
The throughput of kafka sink needs to be improved.
What is changed and how it works?
Batch send messages to consumer
Check List
Tests
Code changes
Side effects
Related changes