-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncer(dm): track skipped ddls when using dmctl binlog to skip some ddls (#4178) #4225
syncer(dm): track skipped ddls when using dmctl binlog to skip some ddls (#4178) #4225
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
/assign @nongfushanquan |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0f37322
|
/run-kafka-integration-test |
1 similar comment
/run-kafka-integration-test |
This is an automated cherry-pick of #4178
What problem does this PR solve?
Issue Number: close #4177 , close #3239
What is changed and how it works?
Track skipped ddls when we use
binlog skip
. However, syncer will only track replaced ddl instead of original ddl forbinlog replace.
Check List
Tests
Use
binlog skip
for *add not fully dropped column` error. DM can replicate data correctly after skip. We don't have to set schema again.Code changes
Side effects
Related changes
Release note