Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer(dm): track skipped ddls when using dmctl binlog to skip some ddls (#4178) #4225

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4178

What problem does this PR solve?

Issue Number: close #4177 , close #3239

What is changed and how it works?

Track skipped ddls when we use binlog skip. However, syncer will only track replaced ddl instead of original ddl for binlog replace.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Use binlog skip for *add not fully dropped column` error. DM can replicate data correctly after skip. We don't have to set schema again.

Code changes

  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation

Release note

Support updating table schema when using dmctl binlog to skip some ddls

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Jan 5, 2022
@overvenus overvenus added this to the v5.3.1 milestone Jan 6, 2022
@lance6716
Copy link
Contributor

dm/syncer/syncer.go:2796:3: unknown field 'eventStatusVars' in struct literal of type queryEventContext
dm/syncer/syncer.go:2821:31: not enough arguments in call to s.genDDLInfo
	have (*queryEventContext, string)
	want (*"github.com/pingcap/tidb/parser".Parser, string, string)

@lichunzhu

@lichunzhu
Copy link
Contributor

/run-all-tests

@lance6716
Copy link
Contributor

/assign @nongfushanquan

@Ehco1996
Copy link
Contributor

Ehco1996 commented Feb 7, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0f37322

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@lichunzhu
Copy link
Contributor

/run-kafka-integration-test

1 similar comment
@Ehco1996
Copy link
Contributor

Ehco1996 commented Feb 8, 2022

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 520e2b0 into pingcap:release-5.3 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants