-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler(cdc): add randomness to the scheduler(V2) #4202
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4202 +/- ##
================================================
+ Coverage 55.1722% 55.1868% +0.0146%
================================================
Files 485 489 +4
Lines 59829 60605 +776
================================================
+ Hits 33009 33446 +437
- Misses 23484 23792 +308
- Partials 3336 3367 +31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a benchmark about addTable
?
/run-leak-tests |
test fails |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5f40346
|
/run-verify |
In response to a cherrypick label: new pull request created: #4236. |
What problem does this PR solve?
Issue Number: close #4203 close #4204 ref #3654
What is changed and how it works?
scheduler/balancer
to 1) add some randomness in choosing dispatch target, 2) add some randomness in choosing victims when rebalancing.Check List
Tests
Performance
Side effects
Related changes
Release note