Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(ticdc): Fix a nil pointer access bug when appending DataPatches (#4085) #4181

Merged
merged 3 commits into from
Jan 20, 2022
Merged

owner(ticdc): Fix a nil pointer access bug when appending DataPatches (#4085) #4181

merged 3 commits into from
Jan 20, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4085

What problem does this PR solve?

Issue Number: close #3128

What is changed and how it works?

Add nil pointer checking when we append DataPatches for ChangefeedReactorState such as PatchInfo, PatchStatus etc.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix the potential panic issue that occurs when changefeed info is removed from etcd.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Dec 31, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 31, 2021
Merged
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2021
@overvenus overvenus added this to the v5.1.4 milestone Jan 6, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 19, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2022
@zhaoxinyu
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test

2 similar comments
@zhaoxinyu
Copy link
Contributor

/run-integration-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d1c2349

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@overvenus
Copy link
Member

/run-integration-test
/run-kafka-integration-test

@overvenus
Copy link
Member

/run-leak-test

@zhaoxinyu
Copy link
Contributor

/run-unit-test

@zhaoxinyu
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 6b0b7a8 into pingcap:release-5.1 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zhaoxinyu zhaoxinyu

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @zhaoxinyu @overvenus @VelocityLight