Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dm): use more adaptive timeout #4141

Merged
merged 3 commits into from
Jan 17, 2022
Merged

test(dm): use more adaptive timeout #4141

merged 3 commits into from
Jan 17, 2022

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4131

What is changed and how it works?

Check List

Tests

  • No code

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 29, 2021
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Dec 29, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021 •
edited
Loading

Codecov Report

Merging #4141 (077cb18) into master (3873d39) will decrease coverage by 1.8296%.
The diff coverage is 68.3383%.

Flag Coverage Δ
cdc 58.7678% <68.3383%> (+0.5312%) ⬆️
dm 52.2240% <ø> (-3.8106%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4141        +/-   ##
================================================
- Coverage   57.0741%   55.2445%   -1.8297%     
================================================
  Files           478        489        +11     
  Lines         56551      60377      +3826     
================================================
+ Hits          32276      33355      +1079     
- Misses        20978      23662      +2684     
- Partials       3297       3360        +63

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 077cb18

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-verify

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-integration-test

@lance6716
Copy link
Contributor Author

/run-kafka-integration-test

2 similar comments
@lance6716
Copy link
Contributor Author

/run-kafka-integration-test

@lance6716
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit a6802a5 into pingcap:master Jan 17, 2022
buchuitoudegou pushed a commit to buchuitoudegou/tiflow that referenced this pull request Jan 18, 2022
@lance6716 @buchuitoudegou
test(dm): use more adaptive timeout (pingcap#4141)
1f0f362 
close pingcap#4131
buchuitoudegou pushed a commit to buchuitoudegou/tiflow that referenced this pull request Jan 18, 2022
@lance6716 @buchuitoudegou
test(dm): use more adaptive timeout (pingcap#4141)
401cf71 
close pingcap#4131
buchuitoudegou pushed a commit to buchuitoudegou/tiflow that referenced this pull request Jan 19, 2022
@lance6716 @buchuitoudegou
test(dm): use more adaptive timeout (pingcap#4141)
46b2f34 
close pingcap#4131
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
@lance6716 @zhaoxinyu
test(dm): use more adaptive timeout (pingcap#4141)
d98cb6c 
close pingcap#4131
@lance6716 lance6716 deleted the fix-ut2 branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testOptimist.TestOptimistLockConflict is not stabled
5 participants
@lance6716 @ti-chi-bot @codecov-commenter @okJiang @Ehco1996