Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix upgrade test #3701

Merged
merged 5 commits into from
Dec 3, 2021
Merged

test: fix upgrade test #3701

merged 5 commits into from
Dec 3, 2021

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Dec 2, 2021 •
edited
Loading

What problem does this PR solve?

fix upgrade test

Release Note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 2, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2021
@GMHDBJD GMHDBJD added component/test Unit tests and integration tests component. area/dm Issues or PRs related to DM. labels Dec 2, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021 •
edited
Loading

Codecov Report

Merging #3701 (b2301c7) into master (7702989) will increase coverage by 0.2970%.
The diff coverage is 81.2154%.

Flag Coverage Δ
cdc 58.2275% <81.2154%> (+0.6079%) ⬆️
dm 56.3752% <ø> (+0.0103%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3701        +/-   ##
================================================
+ Coverage   56.9451%   57.2421%   +0.2970%     
================================================
  Files           455        459         +4     
  Lines         54110      54680       +570     
================================================
+ Hits          30813      31300       +487     
- Misses        20085      20140        +55     
- Partials       3212       3240        +28

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2021
Ehco1996
Ehco1996 approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2021
@Ehco1996
Copy link
Contributor

Ehco1996 commented Dec 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5bbb8a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2021
@ti-chi-bot ti-chi-bot merged commit 3a2d2c5 into pingcap:master Dec 3, 2021
@GMHDBJD GMHDBJD mentioned this pull request Dec 3, 2021
Merged
okJiang pushed a commit to okJiang/tiflow that referenced this pull request Dec 8, 2021
@GMHDBJD @okJiang
test: fix upgrade test (pingcap#3701)
266d6db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @ti-chi-bot @codecov-commenter @Ehco1996 @lance6716