-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kvclient): fix region merging would block the progress of resolveLock (#3062) #3102
fix(kvclient): fix region merging would block the progress of resolveLock (#3062) #3102
Conversation
…ogress of resolveLock. close pingcap#3061
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
1 similar comment
/merge |
/run-kafka-tests |
This is an automated cherry-pick of #3062
What problem does this PR solve?
fix the bug that region merging would block the progress of resolveLock when tidb tx end abnormally and remain some prewrite lock in region. Close #3061 #2867
What is changed and how it works?
(1) When meet a fallback resolvedTs event, we send it to resolveLock thread instead of ignoring it so that resolve lock logic can trigger;
(2) Fallback resolvedTs event will also increase the penalty which will trigger resolve lock eventually.
Check List
Tests
Ref to the step in issue TiCDC does not resolve lock in time #2867
Related changes
Release note