-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink: fix codec json encoding with non binary string (#2764) #2781
sink: fix codec json encoding with non binary string (#2764) #2781
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 28f5d9f
|
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2781 +/- ##
===================================================
+ Coverage 53.7661% 55.2314% +1.4652%
===================================================
Files 153 164 +11
Lines 15958 19746 +3788
===================================================
+ Hits 8580 10906 +2326
- Misses 6475 7805 +1330
- Partials 903 1035 +132 |
This is an automated cherry-pick of #2764
What problem does this PR solve?
Close #2758
Note we still don't known in which scenario the column value is
string
instead of[]byte
, need more investigation.What is changed and how it works?
The column value type of
mysql.TypeString
,mysql.TypeVarString
,mysql.TypeVarchar
could be eitherstring
or[]byte
, we should consider both of these two types when converting a row column value to json encoding.Check List
Tests
Release note