Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: fix schema snapshot read from TiKV (#2604) #2609

Merged
merged 15 commits into from
Sep 7, 2021
Merged

owner: fix schema snapshot read from TiKV (#2604) #2609

merged 15 commits into from
Sep 7, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2604

What problem does this PR solve?

Close #2603

What is changed and how it works?

  • Fixed the timestamp with which to read TiKV snapshot for schema.
  • Improved integration test case ddl_reentrant so that similar bugs will not be reintroduced in the future.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fixed a bug in DDL handling when the owner restarts.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 23, 2021
Merged
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/replica-model Replication model component. release-blocker This issue blocks a release. Please solve it ASAP. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 23, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and liuzix August 23, 2021 10:19
@asddongmen
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 23, 2021
@amyangfei amyangfei added this to the v4.0.15 milestone Aug 23, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei amyangfei mentioned this pull request Aug 27, 2021
Merged
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4b78499

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@overvenus
Copy link
Member

/run-integration-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2021
@liuzix
Copy link
Contributor

liuzix commented Sep 7, 2021

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021 •
edited
Loading

Codecov Report

Merging #2609 (a7c2193) into release-4.0 (753073a) will increase coverage by 1.4347%.
The diff coverage is 58.8389%.

@@                 Coverage Diff                 @@
##           release-4.0      #2609        +/-   ##
===================================================
+ Coverage      53.7661%   55.2008%   +1.4347%     
===================================================
  Files              153        164        +11     
  Lines            15958      19737      +3779     
===================================================
+ Hits              8580      10895      +2315     
- Misses            6475       7806      +1331     
- Partials           903       1036       +133

@liuzix
Copy link
Contributor

liuzix commented Sep 7, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a7c2193

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2021
@ti-chi-bot ti-chi-bot merged commit 982e4f3 into pingcap:release-4.0 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@liuzix liuzix

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.15
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @asddongmen @amyangfei @overvenus @liuzix @codecov-commenter @nongfushanquan