Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_sink: backport async sink to 5.0-branch old owner #2605

Merged
merged 7 commits into from
Aug 31, 2021
Merged

async_sink: backport async sink to 5.0-branch old owner #2605

merged 7 commits into from
Aug 31, 2021

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Aug 23, 2021 •
edited
Loading

What problem does this PR solve?

close #2295

What is changed and how it works?

Backport async sink to old owner and old changefeed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

  • Possible performance regression
  • Increased code complexity

Release note 

This PR make the old owner handle DDL in Async mode.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 23, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2021
@asddongmen asddongmen self-assigned this Aug 23, 2021
@asddongmen asddongmen added component/sink Sink component. component/replica-model Replication model component. and removed component/sink Sink component. labels Aug 23, 2021
@asddongmen asddongmen added this to the v5.0.4 milestone Aug 23, 2021
@asddongmen asddongmen changed the title async_sink: backport async sink to 5.0 async_sink: backport async sink to 5.0-branch old owner Aug 23, 2021
@asddongmen asddongmen linked an issue Aug 23, 2021 that may be closed by this pull request
Solve sink failure interrupting replication in Old Owner #2295
Closed
2 tasks
@asddongmen
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

1 similar comment
@asddongmen
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

@asddongmen asddongmen added the status/ptal Could you please take a look? label Aug 23, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@61d55eb). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2605   +/-   ##
================================================
  Coverage               ?   55.5084%           
================================================
  Files                  ?        165           
  Lines                  ?      19815           
  Branches               ?          0           
================================================
  Hits                   ?      10999           
  Misses                 ?       7768           
  Partials               ?       1048

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 27, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d67f95

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@asddongmen
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei amyangfei added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3bbaf5f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@asddongmen
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

4 similar comments
@asddongmen
Copy link
Contributor Author

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit e2d05eb into pingcap:release-5.0 Aug 31, 2021
@asddongmen asddongmen deleted the backport_asyncSink_to_5.0 branch October 26, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix liuzix approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@asddongmen asddongmen

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.

Solve sink failure interrupting replication in Old Owner
6 participants
@asddongmen @ti-chi-bot @codecov-commenter @amyangfei @liuzix @lonng