-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink/mysql: adjust producer/consumer exit sequence to avoid goroutine leak (#1929) #1946
sink/mysql: adjust producer/consumer exit sequence to avoid goroutine leak (#1929) #1946
Conversation
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
/run-kafka-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2f50566
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #1946 +/- ##
================================================
Coverage ? 54.4158%
================================================
Files ? 163
Lines ? 17471
Branches ? 0
================================================
Hits ? 9507
Misses ? 6944
Partials ? 1020 |
This is an automated cherry-pick of #1929
What problem does this PR solve?
Fix a goroutine leak bug, where the sink worker has exited, but more txns are sent to txn channel of sink worker.
And the producer will wait for the txn to be consumed forever.
What is changed and how it works?
Add a cleanup mechanism for sink worker.
Check List
Tests
Release note