-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix mock server sends event before kv client is ready #1686
tests: fix mock server sends event before kv client is ready #1686
Conversation
/run-all-tests |
we should try to simplify testing of kvclient, but LGTM /lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ec3d19b
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #1690 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #1691 |
What problem does this PR solve?
Fix unstable unit test
What is changed and how it works?
The root cause is new request ID is allocated in kv client first, and then pending region is inserted, when the test code detects request ID is ready, the pending region could be not ready.
This is a fix for the test
Check List
Tests
Release note