owner: fix cleanup stale tasks before capture info is constructed (#1269) #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/run-check-release-note |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1280 +/- ##
===================================================
- Coverage 45.9165% 45.8878% -0.0288%
===================================================
Files 112 112
Lines 11767 11770 +3
===================================================
- Hits 5403 5401 -2
- Misses 5753 5760 +7
+ Partials 611 609 -2 |
amyangfei
approved these changes
Jan 6, 2021
|
LGTM |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
zier-one
approved these changes
Jan 6, 2021
ti-srebot
added
status/LGT3
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1269 to release-4.0
What problem does this PR solve?
Fix https://github.com/pingcap/ticdc/issues/1268, since #1184 has been merged into
release-4.0before4.0.10is released, this PR needs to be shipped in4.0.10too.No release since this is a bug fix in non-release version
What is changed and how it works?
Add a flag to record whether capture information is initialized in owner.
Check List
Tests
Release note