Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: update pull request template #1276

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

update pull request template, add metric document in check list

What is changed and how it works?

add metric document in check list

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added status/ptal Could you please take a look? needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-5.0-rc labels Jan 6, 2021
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
@zier-one
Copy link
Contributor

zier-one commented Jan 6, 2021

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 6, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@zier-one
Copy link
Contributor

zier-one commented Jan 6, 2021

/merge

@ti-srebot
Copy link
Contributor

@amyangfei merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 589e739 into pingcap:master Jan 6, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Jan 6, 2021
@amyangfei amyangfei deleted the update-pr-template branch January 6, 2021 07:16
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants