*: Using the global singleton for pd client and tikv client, and fix pd client freeze (#1217) #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
type/bugfix
|
LGTM |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1219 +/- ##
===================================================
+ Coverage 39.6736% 39.7041% +0.0304%
===================================================
Files 112 112
Lines 11766 11762 -4
===================================================
+ Hits 4668 4670 +2
+ Misses 6625 6621 -4
+ Partials 473 471 -2 |
amyangfei
approved these changes
Dec 16, 2020
ti-srebot
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1217 to release-4.0
What problem does this PR solve?
Using the global singleton for pd client and tikv client, and fix pd client freeze
What is changed and how it works?
The modification of this PR bypasses the bug about pd client freeze by using a global singleton for pd client
Check List
Tests
Release note