Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resign owner api not processed by owner node bug (#11770) #11780

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11770

What problem does this PR solve?

Issue Number: close #11769

What is changed and how it works?

/api/v2/owner/resign forward to owner node

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@8ccf02c). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.6912% <0.0000%> (?)
dm 50.0943% <0.0000%> (?)
engine 53.2618% <0.0000%> (?)
Flag Coverage Δ
unit 55.2115% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11780   +/-   ##
================================================
  Coverage               ?   55.2115%           
================================================
  Files                  ?       1002           
  Lines                  ?     136716           
  Branches               ?          0           
================================================
  Hits                   ?      75483           
  Misses                 ?      55728           
  Partials               ?       5505           

@sdojjy
Copy link
Member

sdojjy commented Nov 27, 2024

/retest-required

1 similar comment
@sdojjy
Copy link
Member

sdojjy commented Nov 27, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 2, 2024

@asddongmen: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to adding label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the approved label Dec 2, 2024
@asddongmen
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2024
@flowbehappy
Copy link
Collaborator

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 3, 2024

@flowbehappy: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@flowbehappy
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, flowbehappy, sdojjy, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flowbehappy flowbehappy merged commit a0e1d48 into pingcap:release-8.5 Dec 3, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants