-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): return invalid topic expression in ErrKafkaInvalidTopicExpression #11161
sink(ticdc): return invalid topic expression in ErrKafkaInvalidTopicExpression #11161
Conversation
820338d
to
7003e53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11161 +/- ##
================================================
+ Coverage 57.6250% 57.8161% +0.1910%
================================================
Files 849 850 +1
Lines 126261 127205 +944
================================================
+ Hits 72758 73545 +787
- Misses 48098 48233 +135
- Partials 5405 5427 +22 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #11160
What is changed and how it works?
return invalid topic expression in ErrKafkaInvalidTopicExpression to facilitate troubleshooting.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note