Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(cdc): accept access denied error when query tidb_version (#11129) #11142

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11129

What problem does this PR solve?

Issue Number: close #11128

What is changed and how it works?

When the downstream is a mysql cluster behind a workload balancer on the cloud, the workload balancer may provide an access point using domain name;
When cdc access the downstream using the domain name, the connection will use database information_schema automatically. In this case, when query select tidb_version(), the downstream will report error for non-root user like: Access denied for user xxx to database 'information_schema'.
image

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 20, 2024
@lidezhu
Copy link
Collaborator

lidezhu commented May 20, 2024

/test verify

@lidezhu
Copy link
Collaborator

lidezhu commented May 20, 2024

/test pull-cdc-integration-storage-test

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

@lidezhu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-pulsar-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run all jobs.

In response to this:

/test pull-cdc-integration-storage-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lidezhu
Copy link
Collaborator

lidezhu commented May 20, 2024

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 20, 2024
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

@lidezhu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lidezhu lidezhu requested review from hicqu and asddongmen May 20, 2024 08:18
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4066cba into pingcap:release-7.5 May 20, 2024
12 of 13 checks passed
@lidezhu lidezhu deleted the cherry-pick-11129-to-release-7.5 branch May 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants