Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: adjust sorter options to avoid Seek CPU usage exploding (#11099) #11135

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11099

What problem does this PR solve?

Issue Number: close #11078

What is changed and how it works?

  • trigger compaction more frequently
  • use a better hash function for table IDs

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu added 3 commits May 17, 2024 06:35
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2024
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label May 17, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 17, 2024
Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-8.1@f98b245). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.6727% <0.0000%> (?)
dm 51.2607% <0.0000%> (?)
engine 63.4373% <0.0000%> (?)
Flag Coverage Δ
unit 57.4225% <66.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11135   +/-   ##
================================================
  Coverage               ?   57.4225%           
================================================
  Files                  ?        852           
  Lines                  ?     125698           
  Branches               ?          0           
================================================
  Hits                   ?      72179           
  Misses                 ?      48099           
  Partials               ?       5420           

@hicqu
Copy link
Contributor

hicqu commented May 17, 2024

/retest

@hicqu
Copy link
Contributor

hicqu commented May 17, 2024

/test cdc-integration-pulsar-test

@hicqu
Copy link
Contributor

hicqu commented May 17, 2024

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 5a2fbdd into pingcap:release-8.1 May 17, 2024
27 checks passed
@hicqu hicqu deleted the cherry-pick-11099-to-release-8.1 branch May 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants