-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize the calculation method of ticdc's gc saftpoint #8403
Labels
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
area/ticdc
Issues or PRs related to TiCDC.
type/enhancement
The issue or PR belongs to an enhancement.
Comments
/area ticdc |
/assign @charleszheng44 |
/label affects-7.1 |
charleszheng44
added a commit
to charleszheng44/tiflow
that referenced
this issue
May 6, 2023
Rustin170506
added
type/enhancement
The issue or PR belongs to an enhancement.
and removed
type/feature
Issues about a new feature
labels
May 6, 2023
/label affects-6.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
area/ticdc
Issues or PRs related to TiCDC.
type/enhancement
The issue or PR belongs to an enhancement.
Is your feature request related to a problem?
As for one upstream in lots of changefeeds scenarios, if one changefeed fails and other changefeed work normal, ticdc will ignore the checkpoint ts of the failed changefeed and use the the checkpoint ts of the normal one as gc safe point. So the tidb would gc some data before the customer handle the error.
Describe the feature you'd like
if one changefeed fails, the gc safe-point can hold for 24h . The calculation method is as followed:
If changefeed1: failed (check point ts = ts1),changefeed2 normal checkpoint ts = ts2.
Then Gc safepoint = min( ts2, max( ts1, currentPDts - 24h))
Describe alternatives you've considered
No response
Teachability, Documentation, Adoption, Migration Strategy
No response
The text was updated successfully, but these errors were encountered: