Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure do not update checkpoint ts when sink is stopping #7274

Closed
Rustin170506 opened this issue Sep 30, 2022 · 0 comments · Fixed by #7275
Closed

Make sure do not update checkpoint ts when sink is stopping #7274

Rustin170506 opened this issue Sep 30, 2022 · 0 comments · Fixed by #7275
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@Rustin170506
Copy link
Member

What did you do?

e.state.Store(state.TableSinkStopping)

In this code, it might cause us to update checkpoints when the sink is stopping.

For example:

  1. set state is stopping
  2. drop the data in the backend sink (Concurrent with 1)
  3. advance the checkpoint ts (Concurrent with 1)
  4. try to close

What did you expect to see?

Do not update checkpoint ts.

What did you see instead?

Do update checkpoint ts.

Versions of the cluster

TiCDC version (execute cdc version):

master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant