Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masking of sink-uri doesn't mask sasl-password for Kafka URIs #7182

Closed
dveeden opened this issue Sep 22, 2022 · 3 comments · Fixed by #7184
Closed

Masking of sink-uri doesn't mask sasl-password for Kafka URIs #7182

dveeden opened this issue Sep 22, 2022 · 3 comments · Fixed by #7184
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.

Comments

@dveeden
Copy link
Contributor

dveeden commented Sep 22, 2022

What did you do?

Use a sink-uri like kafka://...?sasl-mechanism=SCRAM-SHA-256&sasl-password=xxxxx&sasl-user=ticdc

tiup cdc cli changefeed query --pd=http://127.0.0.1:2379 --changefeed-id=test-changefeed

What did you expect to see?

The sasl-password to be masked, just like the MySQL password in mysql:// uris

What did you see instead?

Unmasked sasl-password

Versions of the cluster

v6.1.1
@dveeden dveeden added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Sep 22, 2022
@dveeden dveeden mentioned this issue Sep 22, 2022
Merged
@dveeden
Copy link
Contributor Author

dveeden commented Sep 22, 2022

/severity minor

ti-chi-bot pushed a commit that referenced this issue Sep 23, 2022
@dveeden
util: mask sasl-password in sink-uri (#7184)
d32cbe8 
close #7182
@ti-chi-bot ti-chi-bot mentioned this issue Jan 11, 2023
Merged
@nongfushanquan
Copy link
Contributor

/label affects-6.1
/label affects-6.5

@ti-chi-bot ti-chi-bot added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Jan 12, 2023
@nongfushanquan
Copy link
Contributor

/remove affects-6.5

@nongfushanquan nongfushanquan mentioned this issue Feb 3, 2023
Merged
14 tasks
@Rustin170506 Rustin170506 removed the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: mask sasl-password in sink-uri dveeden/tiflow
4 participants
@dveeden @Rustin170506 @ti-chi-bot @nongfushanquan