Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo manager should only clean files of one specified changefeed instead of all changefeeds #6413

Closed
4 tasks done
hicqu opened this issue Jul 21, 2022 · 10 comments · Fixed by #7279
Closed
4 tasks done

redo manager should only clean files of one specified changefeed instead of all changefeeds #6413

hicqu opened this issue Jul 21, 2022 · 10 comments · Fixed by #7279
Assignees
@asddongmen
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.3 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.

Comments

@hicqu
Copy link
Contributor

hicqu commented Jul 21, 2022 •
edited
Loading

Before asking a question, make sure you have

What is your question?

Test shows there is a bug about cleaning redo-log files when removing a changefeed:

  • when removing a changefeed, managerImpl.Cleanup will be called;
  • then LogWriter.DeleteAllLogs will be called, and all files in the redo-log directory and S3 path will be deleted;
  • so if several changefeeds share one redo-log directory or S3 bucket, their redo files will be deleted incorrectly.

The bug should effect all versions.
@hicqu hicqu added the question Further information is requested. label Jul 21, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Jul 21, 2022

/type bug

@ti-chi-bot ti-chi-bot added the type/bug The issue is confirmed as a bug. label Jul 21, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Jul 21, 2022

/label effects-6.1
/severity majority
/remove-label question

@ti-chi-bot
Copy link
Member

@hicqu: The label(s) effects-6.1 cannot be applied. These labels are supported: duplicate, bug-from-internal-test, bug-from-user, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, question, release-blocker, wontfix, require-LGT1, require-LGT3.

In response to this:

/label effects-6.1
/severity majority
/remove-label question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the question Further information is requested. label Jul 21, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Jul 21, 2022

/label affects-6.1
/severity majority
/remove-label question

@ti-chi-bot
Copy link
Member

@hicqu: The label(s) severity/majority cannot be applied, because the repository doesn't have them.

In response to this:

/label affects-6.1
/severity majority
/remove-label question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Jul 21, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Jul 21, 2022

/severity major
/remove-label question

@ti-chi-bot
Copy link
Member

@hicqu: These labels are not set on the issue: question.

In response to this:

/severity major
/remove-label question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu
Copy link
Contributor Author

hicqu commented Jul 21, 2022

/remove-label may-affects-4.0
/remove-label may-affects-5.0
/remove-label may-affects-5.1
/remove-label may-affects-5.2
/remove-label may-affects-5.3
/remove-label may-affects-5.4
/remove-label may-affects-6.0
/remove-label may-affects-6.2

@nongfushanquan
Copy link
Contributor

/area ticdc

@ti-chi-bot ti-chi-bot added the area/ticdc Issues or PRs related to TiCDC. label Jul 28, 2022
@nongfushanquan
Copy link
Contributor

/assign @asddongmen

@asddongmen asddongmen mentioned this issue Sep 30, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Oct 10, 2022
@asddongmen
redo (ticdc): only delete changefeed related file when changefeed was…
3ede032 
… removed (#7279)

close #6413
This was referenced Oct 10, 2022
Merged
Closed
ti-chi-bot added a commit that referenced this issue Oct 10, 2022
@ti-chi-bot
redo (ticdc): only delete changefeed related file when changefeed was…
4af5e75 
… removed (#7279) (#7305)

close #6413
@nongfushanquan nongfushanquan mentioned this issue Oct 19, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asddongmen asddongmen

Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.3 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redo (ticdc): only delete changefeed related file when changefeed was removed asddongmen/tiflow
5 participants
@hicqu @VelocityLight @asddongmen @ti-chi-bot @nongfushanquan