storage: fix block rows not match when filter column is the first non-empty column in the block (#9483) #9495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9483
What problem does this PR solve?
Issue Number: ref #9472
Problem Summary:
What is changed and how it works?
Try to fix #9472, failed to reproduce the issue. But when the filter column is the first non-empty column in the block,
block.rows() = filter_column->size()
, but filter_column is not filtered, so the rows may not match.But filter_column is usually added to the back of the block, so it is kind of weird.
Check List
Tests
Side effects
Documentation
Release note