Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join be aware of cancel signal (#9450) #9453

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9450

What problem does this PR solve?

Issue Number: close #9430

Problem Summary:

What is changed and how it works?

Check cancel signal inside join


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Cancel a query with a cross join

mysql> select count(*) from t1;
+----------+
| count(*) |
+----------+
|  8000392 |
+----------+
mysql> explain select count(*) from t1 where id not in (select id from t1);
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| id                                       | estRows    | task         | access object | operator info                                                   |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+
| HashAgg_35                               | 1.00       | root         |               | funcs:count(Column#8)->Column#7                                 |
| └─TableReader_37                         | 1.00       | root         |               | MppVersion: 2, data:ExchangeSender_36                           |
|   └─ExchangeSender_36                    | 1.00       | mpp[tiflash] |               | ExchangeType: PassThrough                                       |
|     └─HashAgg_13                         | 1.00       | mpp[tiflash] |               | funcs:count(1)->Column#8                                        |
|       └─HashJoin_34                      | 6400313.60 | mpp[tiflash] |               | CARTESIAN anti semi join, other cond:eq(test.t1.id, test.t1.id) |
|         ├─ExchangeReceiver_21(Build)     | 8000392.00 | mpp[tiflash] |               |                                                                 |
|         │ └─ExchangeSender_20            | 8000392.00 | mpp[tiflash] |               | ExchangeType: Broadcast, Compression: FAST                      |
|         │   └─TableFullScan_19           | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
|         └─TableFullScan_18(Probe)        | 8000392.00 | mpp[tiflash] | table:t1      | keep order:false                                                |
+------------------------------------------+------------+--------------+---------------+-----------------------------------------------------------------+

Before this pr
屏幕截图 2024-09-20 165644

After this pr
屏幕截图 2024-09-20 170114

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix bug that join can not be cancelled timely.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2024
12 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 21, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 23, 2024
@windtalker
Copy link
Contributor

/run-all-tests

@windtalker
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@windtalker windtalker mentioned this pull request Sep 23, 2024
12 tasks
Signed-off-by: xufei <[email protected]>
@windtalker windtalker force-pushed the cherry-pick-9450-to-release-7.5 branch from d9a06b1 to 95f73a8 Compare September 24, 2024 09:30
@windtalker
Copy link
Contributor

/run-all-tests

Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 01:44:14.795108441 +0000 UTC m=+1443924.535532380: ☑️ agreed by windtalker.
  • 2024-09-26 09:19:41.292107572 +0000 UTC m=+1730451.032531511: ☑️ agreed by yibin87.

@windtalker
Copy link
Contributor

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2faf287 into pingcap:release-7.5 Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants