-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
join be aware of cancel signal (#9450) #9453
join be aware of cancel signal (#9450) #9453
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/run-all-tests |
/hold |
ref pingcap#9430 Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
d9a06b1
to
95f73a8
Compare
/run-all-tests |
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold cancel |
This is an automated cherry-pick of #9450
What problem does this PR solve?
Issue Number: close #9430
Problem Summary:
What is changed and how it works?
Check cancel signal inside join
Check List
Tests
Cancel a query with a cross join
Before this pr

After this pr

Side effects
Documentation
Release note