ddl: Support FLASHBACK DATABASE (release-7.5) (#8424)
#8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note
12 tasks
ti-chi-bot
added
the
cherry-pick-approved
JaySon-Huang
changed the title
FLASHBACK DATABASE (#8424)FLASHBACK DATABASE (release-7.5) (#8424)
JaySon-Huang
force-pushed
the
cherry-pick-8424-to-release-7.5
branch
from
944c6b9 to
35c2e8b
Compare
|
/run-all-tests |
|
|
/run-unit-test |
|
https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-unit-tests/detail/tiflash-ghpr-unit-tests/12108/pipeline |
|
/run-unit-test |
JaySon-Huang
approved these changes
Dec 7, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Lloyd-Pottiger
approved these changes
Dec 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8424
What problem does this PR solve?
Issue Number: close #8450
Problem Summary:
tidb support
FLASHBACK DATABASE DBName [TO newDBName]since v6.4.0 https://docs.pingcap.com/tidb/stable/sql-statement-flashback-databaseAfter executing
FLASHBACK DATABASE ... TO ..., the storage instances in TiFlash are not recovered as non tombstone. After the gc safepoint advanced, the storage instances will be physically drop.What is changed and how it works?
Recover all the tables on the database when
FLASHBACK DATABASEis executed.Note that the implementation is different from that on release-7.1, release-6.5
Check List
Tests
Side effects
Documentation
Release note