-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Fix max snapshot lifetime is not shown on Grafana (#8102) #8103
*: Fix max snapshot lifetime is not shown on Grafana (#8102) #8103
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/run-all-tests |
/approve |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #8102
What problem does this PR solve?
Issue Number: close #7713
Problem Summary:
After #7706, when PS V3 or UniPS is enabled, the metrics of max snapshot lifetime is always reported to prometheus as 0.
What is changed and how it works?
When PS V3 or UniPS is enabled, get and report the metrics in
AsynchronousMetrics::update
Check List
Tests
DBGInvoke disable_fail_point(hang_in_execution)
throughtiflash client
Side effects
Documentation
Release note