Retry when meet DNS error when requesting TiKV's status server #8061

CalvinNeo · 2023-09-06T07:06:53Z

What problem does this PR solve?

Issue Number: close #8059

Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy 8872f4d7f7..bd85bf8028:

Retry when DNS resolution to TiKV status server fails (#353)
Show enable-features in TiFlash (#352)

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: CalvinNeo <[email protected]>

ti-chi-bot · 2023-09-06T07:59:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-09-06T07:59:30Z

[LGTM Timeline notifier]

Timeline:

2023-09-06 07:58:43.391241794 +0000 UTC m=+2518687.940257784: ☑️ agreed by JaySon-Huang.
2023-09-06 07:59:29.755979911 +0000 UTC m=+2518734.304995901: ☑️ agreed by Lloyd-Pottiger.

JaySon-Huang · 2023-09-06T08:49:30Z

/run-all-tests

JaySon-Huang · 2023-09-07T06:08:45Z

[2023-09-07T05:18:37.108Z] [2023/09/07 13:18:22.840 +08:00] [ERROR] [BaseDaemon.cpp:370] [########################################] [source=BaseDaemon] [thread_id=3]
[2023-09-07T05:18:37.108Z] [2023/09/07 13:18:22.840 +08:00] [ERROR] [BaseDaemon.cpp:371] ["(from thread 2) Received signal Segmentation fault(11)."] [source=BaseDaemon] [thread_id=3]
[2023-09-07T05:18:37.108Z] [2023/09/07 13:18:22.840 +08:00] [ERROR] [BaseDaemon.cpp:399] ["Address: NULL pointer."] [source=BaseDaemon] [thread_id=3]
[2023-09-07T05:18:37.108Z] [2023/09/07 13:18:22.840 +08:00] [ERROR] [BaseDaemon.cpp:407] ["Access: read."] [source=BaseDaemon] [thread_id=3]
[2023-09-07T05:18:37.108Z] [2023/09/07 13:18:22.840 +08:00] [ERROR] [BaseDaemon.cpp:416] ["Address not mapped to object."] [source=BaseDaemon] [thread_id=3]
[2023-09-07T05:18:37.108Z] [2023/09/07 13:18:23.052 +08:00] [ERROR] [BaseDaemon.cpp:563] ["
       0xc49e14b\tfaultSignalHandler(int, siginfo_t*, void*) [tiflash+206168395]
  0x7fd226da8630\t<unknown symbol> [libpthread.so.0+63024]
  0x7fd230e1a55c\tedata_szind_get_maybe_invalid [libtiflash_proxy.so+160806236]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/include/jemalloc/internal/edata.h:267
  0x7fd230e1a535\tedata_szind_get [libtiflash_proxy.so+160806197]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/include/jemalloc/internal/edata.h:275
  0x7fd230e0ffb5\tedata_usize_get [libtiflash_proxy.so+160763829]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/include/jemalloc/internal/edata.h:282
  0x7fd230e1445c\t_rjem_je_arena_ralloc_no_move [libtiflash_proxy.so+160781404]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/src/arena.c:1437
  0x7fd230e14eb5\t_rjem_je_arena_ralloc [libtiflash_proxy.so+160784053]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/src/arena.c:1468
  0x7fd230df1f60\tdo_rallocx [libtiflash_proxy.so+160640864]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/src/jemalloc.c:3537
  0x7fd230de1bca\trealloc [libtiflash_proxy.so+160574410]
                \t/home/jenkins/agent/workspace/tiflash-build-common/build/contrib/tiflash-proxy-cmake/debug/build/tikv-jemalloc-sys-d32ab80fa3f3ff9c/out/build/src/jemalloc.c:3627
  0x7fd2328905fc\t_$LT$tikv_jemallocator..Jemalloc$u20$as$u20$core..alloc..global..GlobalAlloc$GT$::realloc::hd6fdc7da29b0b32c [libtiflash_proxy.so+188552700]
  0x7fd232891237\t__rg_realloc [libtiflash_proxy.so+188555831]
  0x7fd232907442\talloc::raw_vec::finish_grow::hbb718dfe85210a31 [libtiflash_proxy.so+189039682]
                \t/rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/alloc/src/raw_vec.rs:466
  0x7fd2329081a7\talloc::raw_vec::RawVec$LT$T$C$A$GT$::reserve::do_reserve_and_handle::he9b9b9b562ec5dab [libtiflash_proxy.so+189043111]
                \t/rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/alloc/src/raw_vec.rs:285
  0x7fd232921e6b\tstd::path::Path::_join::h1f435de828e457cd [libtiflash_proxy.so+189148779]
                \t/rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/std/src/path.rs:2461
  0x7fd2315c8a50\tstd::path::Path::join::h72cb84557f293e9c [libtiflash_proxy.so+168860240]
  0x7fd2313590a6\ttikv_util::config::canonicalize_log_dir::h38c853252d71deda [libtiflash_proxy.so+166305958]
  0x7fd22dfed2a9\tserver::setup::make_engine_log_path::h8b2b10754a7fdacc [libtiflash_proxy.so+112386729]
  0x7fd22dfedda4\tserver::setup::initial_logger::h317aa11e73925794 [libtiflash_proxy.so+112389540]
  0x7fd22b027f1e\tproxy_server::run::run_tikv_proxy::h9a4f4e7949ba4c4c [libtiflash_proxy.so+62295838]
  0x7fd22b027da4\tproxy_server::proxy::run_proxy::hf4732e2f67f880f9 [libtiflash_proxy.so+62295460]
  0x7fd22a85f0d7\trun_raftstore_proxy_ffi [libtiflash_proxy.so+54132951]
       0x41ea11f\tDB::RaftStoreProxyRunner::runRaftStoreProxyFFI(void*) [tiflash+69116191]
  0x7fd226da0ea5\tstart_thread [libpthread.so.0+32421]"] [source=BaseDaemon] [thread_id=3]

JaySon-Huang · 2023-09-07T07:07:55Z

/hold

Signed-off-by: CalvinNeo <[email protected]>

…ics into update_proxy_20230906_150612

CalvinNeo · 2023-09-07T07:17:14Z

/run-all-tests

CalvinNeo · 2023-09-07T07:48:22Z

/run-unit-test

JaySon-Huang · 2023-09-07T07:59:56Z

/unhold

ti-chi-bot · 2023-09-07T08:00:13Z

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

CalvinNeo · 2023-09-07T08:58:09Z

/run-integration-test

update tiflash proxy to proxy_up/raftstore-proxy

53f9e82

Signed-off-by: CalvinNeo <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Sep 6, 2023

CalvinNeo changed the title ~~update proxy of master to raftstore-proxy~~ Retry when meet DNS error when requesting TiKV's status server Sep 6, 2023

CalvinNeo requested review from JaySon-Huang, lidezhu and Lloyd-Pottiger September 6, 2023 07:07

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Sep 6, 2023

JaySon-Huang approved these changes Sep 6, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2023

Lloyd-Pottiger approved these changes Sep 6, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 6, 2023

Merge branch 'master' into update_proxy_20230906_150612

19638dd

Merge branch 'master' into update_proxy_20230906_150612

d0f1f29

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023

CalvinNeo added 2 commits September 7, 2023 15:15

f

2fd983b

Signed-off-by: CalvinNeo <[email protected]>

Merge branch 'update_proxy_20230906_150612' of github.com:CalvinNeo/t…

b9ecb3f

…ics into update_proxy_20230906_150612

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023

Merge branch 'master' into update_proxy_20230906_150612

9cb3526

ti-chi-bot bot merged commit 8527afd into pingcap:master Sep 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retry when meet DNS error when requesting TiKV's status server #8061

Retry when meet DNS error when requesting TiKV's status server #8061

CalvinNeo commented Sep 6, 2023 •

edited

Loading

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

JaySon-Huang commented Sep 6, 2023

JaySon-Huang commented Sep 7, 2023

JaySon-Huang commented Sep 7, 2023

CalvinNeo commented Sep 7, 2023

CalvinNeo commented Sep 7, 2023

JaySon-Huang commented Sep 7, 2023

ti-chi-bot bot commented Sep 7, 2023

CalvinNeo commented Sep 7, 2023

Retry when meet DNS error when requesting TiKV's status server #8061

Retry when meet DNS error when requesting TiKV's status server #8061

Conversation

CalvinNeo commented Sep 6, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Sep 6, 2023

ti-chi-bot bot commented Sep 6, 2023

[LGTM Timeline notifier]

JaySon-Huang commented Sep 6, 2023

JaySon-Huang commented Sep 7, 2023

JaySon-Huang commented Sep 7, 2023

CalvinNeo commented Sep 7, 2023

CalvinNeo commented Sep 7, 2023

JaySon-Huang commented Sep 7, 2023

ti-chi-bot bot commented Sep 7, 2023

CalvinNeo commented Sep 7, 2023

CalvinNeo commented Sep 6, 2023 •

edited

Loading