-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce UniPS snapshot stat overhead (#7706) #7716
Merged
ti-chi-bot
merged 2 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-7706-to-release-6.5
Jun 30, 2023
Merged
Reduce UniPS snapshot stat overhead (#7706) #7716
ti-chi-bot
merged 2 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-7706-to-release-6.5
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
/run-all-tests |
/rebuild |
/run-integration-test |
JaySon-Huang
approved these changes
Jun 30, 2023
lidezhu
approved these changes
Jun 30, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #7706
What problem does this PR solve?
Issue Number: close #7713
Problem Summary:
When there are many DeltaMergeStore in one tiflash instance, each
DeltaMergeStore::getStoreStats
will try to get the snapshot stats from PSV3/UniPS. But the PSV3/UniPS is a global instance that brings much CPU waste and locks contention. So it causes slow queries.What is changed and how it works?
PageStorageRunMode::ONLY_V2
, because PSV2 have different PS instances for different tableread_write_mutex
inDeltaMergeStore::getStoreStats
Check List
Tests
Side effects
Documentation
Release note