-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce UniPS snapshot stat overhead (#7706) #7715
Reduce UniPS snapshot stat overhead (#7706) #7715
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/run-all-tests |
/run-unit-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/run-unit-test |
This is an automated cherry-pick of #7706
What problem does this PR solve?
Issue Number: close #7713
Problem Summary:
When there are many DeltaMergeStore in one tiflash instance, each
DeltaMergeStore::getStoreStats
will try to get the snapshot stats from PSV3/UniPS. But the PSV3/UniPS is a global instance that brings much CPU waste and locks contention. So it causes slow queries.What is changed and how it works?
PageStorageRunMode::ONLY_V2
, because PSV2 have different PS instances for different tableread_write_mutex
inDeltaMergeStore::getStoreStats
Check List
Tests
Side effects
Documentation
Release note