Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support late materialization #6966

Merged
merged 31 commits into from
Mar 16, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Mar 6, 2023

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: ref #5829

Problem Summary:

What is changed and how it works?

RFC: pingcap/tidb#39654

  1. Support push down filters in storage layer
  2. Refine extra cast actions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
# tpch-1
> tiup bench tpch prepare
> tiup bench tpch run --check #pass
> tiup bench tpch run --check --conn-params tidb_enable_late_materialization=ON #pass

# clickbench
> AWS_ACCESS_KEY_ID=xxx AWS_SECRET_ACCESS_KEY=xxx tiup br restore table --db hits -s s3://benchmark/clickbench-hits --s3.endpoint http://xxx.xx/ --send-credentials-to-tikv=true --pd ${pd_ip}:${pd_port} --table hits
> mysql --host xxx --port < clickbench.sql > output # master
> mysql --host xxx --port < clickbench.sql > output1 # this pr, set tidb_enable_late_materialization=ON
> git diff --no-index output output1
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support late materialization, push down some predicates to storage layer to reduce the amount of data to be read.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hongyunyan
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 6, 2023
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the support-late-materialization branch from 751a8e6 to cac69a5 Compare March 6, 2023 09:57
Lloyd-Pottiger and others added 4 commits March 7, 2023 10:00
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@pingcap pingcap deleted a comment from sre-bot Mar 10, 2023
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2023
dbms/src/Flash/Coprocessor/DAGUtils.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Coprocessor/DAGUtils.cpp Outdated Show resolved Hide resolved
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update the pr description.

@@ -931,18 +932,15 @@ bool DAGExpressionAnalyzer::buildExtraCastsAfterTS(
const auto fsp = table_scan_columns[i].decimal < 0 ? 0 : table_scan_columns[i].decimal;
tipb::Expr fsp_expr = constructInt64LiteralTiExpr(fsp);
fsp_col = getActions(fsp_expr, actions);
String casted_name = appendDurationCast(fsp_col, source_columns[i].name, dur_func_name, actions);
source_columns[i].name = casted_name;
casted_name = appendDurationCast(fsp_col, source_columns[i].name, dur_func_name, actions);
source_columns[i].type = actions->getSampleBlock().getByName(casted_name).type;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not change the type of source_columns here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should change. a, b, c, cast_c -> a, b, c, here, cast_c is renamed to c, so source_columns[2].type should equal to cast_c's type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it is a little hack compare to the original implementation, how about we still change the name to cast_c, and let the following project to rename cast_c to c?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok. But why this is hack? IMHO, It is normal projection, which aims to replace original c with cast_c.

case PROJECT:
{
    Block new_block;

    for (const auto & projection : projections)
    {
        const std::string & name = projection.first;
        const std::string & alias = projection.second;
        ColumnWithTypeAndName column = block.getByName(name);
        if (!alias.empty())
            column.name = alias;
        new_block.insert(std::move(column));
    }

    block.swap(new_block);

    break;
}

Signed-off-by: Lloyd-Pottiger <[email protected]>
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compute part LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a77301a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit b82b0ba into pingcap:master Mar 16, 2023
@Lloyd-Pottiger Lloyd-Pottiger deleted the support-late-materialization branch March 30, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants