-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support late materialization #6966
Support late materialization #6966
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Lloyd-Pottiger <[email protected]>
751a8e6
to
cac69a5
Compare
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
/run-all-tests |
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
/run-all-tests |
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
/run-all-tests |
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should update the pr description.
@@ -931,18 +932,15 @@ bool DAGExpressionAnalyzer::buildExtraCastsAfterTS( | |||
const auto fsp = table_scan_columns[i].decimal < 0 ? 0 : table_scan_columns[i].decimal; | |||
tipb::Expr fsp_expr = constructInt64LiteralTiExpr(fsp); | |||
fsp_col = getActions(fsp_expr, actions); | |||
String casted_name = appendDurationCast(fsp_col, source_columns[i].name, dur_func_name, actions); | |||
source_columns[i].name = casted_name; | |||
casted_name = appendDurationCast(fsp_col, source_columns[i].name, dur_func_name, actions); | |||
source_columns[i].type = actions->getSampleBlock().getByName(casted_name).type; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not change the type of source_columns here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should change. a, b, c, cast_c
-> a, b, c
, here, cast_c
is renamed to c
, so source_columns[2].type
should equal to cast_c
's type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it is a little hack compare to the original implementation, how about we still change the name to cast_c
, and let the following project to rename cast_c
to c
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok. But why this is hack? IMHO, It is normal projection, which aims to replace original c
with cast_c
.
case PROJECT:
{
Block new_block;
for (const auto & projection : projections)
{
const std::string & name = projection.first;
const std::string & alias = projection.second;
ColumnWithTypeAndName column = block.getByName(name);
if (!alias.empty())
column.name = alias;
new_block.insert(std::move(column));
}
block.swap(new_block);
break;
}
Signed-off-by: Lloyd-Pottiger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compute part LGTM
/merge |
@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a77301a
|
@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-integration-test |
Signed-off-by: Lloyd-Pottiger [email protected]
What problem does this PR solve?
Issue Number: ref #5829
Problem Summary:
What is changed and how it works?
RFC: pingcap/tidb#39654
Check List
Tests
Side effects
Documentation
Release note