Support read(filter, true) in FilterBlockInputStream

[Lloyd-Pottiger]

Support read(filter, true) in FilterBlockInputStream and ExpressionBlockInputStream

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: ref #5829

Problem Summary:

What is changed and how it works?

1. Support read(filter, true) in FilterBlockInputStream.
2. remove some useless tests.
3. remove useless projection in push down filter.

Why do this?

We will reuse the filter return by read(filter, true) to filter out unnesscessary data packs when doing late materialization.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

replace Block readImpl() with

Block readImpl() override
{
Block res = readImpl(filter, true);
if (filter && res)
{
    size_t passed_rows = countBytesInFilter(*filter);
    for (auto & col : res)
    {
        col.column = col.column->filter(*filter, passed_rows);
    }
}
return res;
}

and run unit test ./dbms/gtests_dbms --gtest_filter="FilterExecutorTestRunner*"

• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• SeaRise
• ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

/run-all-tests

[Lloyd-Pottiger]

/run-integration-test

[Lloyd-Pottiger]

/run-all-tests

[Lloyd-Pottiger]

/run-unit-test

[Lloyd-Pottiger]

/run-integration-test

[SeaRise]

I prefer the original code.
Both have the same effect, but the original code is more readable.
Because the original code added the project action explicitly, instead of letting ExpressionActionChain::finalize add it implicitly.

[Lloyd-Pottiger]

The original code get two same projection...

[SeaRise]

ok..

[Lloyd-Pottiger]

done

[SeaRise]

/cc @windtalker

[SeaRise]

Others LGTM

[JaySon-Huang]

this useless CMakeLists.txt can also be removed

[Lloyd-Pottiger]

there is a gtest left, can not removed.

[Lloyd-Pottiger]

/run-all-tests

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 92c000d