-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(README) : Prepare Prerequisites on Arch Linux #6799
Conversation
After I install arch linux and prepare according to the prompt of README.MD. When I excute the commands follows , error occurs. ``` # In the TiFlash repository root: mkdir cmake-build-debug # The directory name can be customized cd cmake-build-debug cmake .. -GNinja -DCMAKE_BUILD_TYPE=DEBUG ninja tiflash ``` error(cmake/tools.cmake:87): ``` Cannot find ar. ``` After excute ``` sudo pacman -S llvm ``` No error occurs again.
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @xiaguan! |
Thanks for your contribution. But we have mention llvm in line59 - 61 🤔 |
I just read the 59-61 lines of readme.md. Is that the content of Ubuntu not Arch Linux ? |
/run-all-tests |
/merge |
@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 54956c4
|
After I install arch linux and prepare according to the prompt of README.MD. When I excute the commands follows , error occurs.
error(cmake/tools.cmake:87):
After excute
No error occurs again.
What problem does this PR solve?
Issue Number: close #6800
Problem Summary: Prepare Prerequisites on Arch Linux is not enough. We should add ' llvm ' .
What is changed and how it works?
Just append ' llvm ' in prepare commands on Arch Linux in
README.md
Check List
Side effects
Documentation
Release note