Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(README) : Prepare Prerequisites on Arch Linux #6799

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

xiaguan
Copy link
Contributor

@xiaguan xiaguan commented Feb 12, 2023

After I install arch linux and prepare according to the prompt of README.MD. When I excute the commands follows , error occurs.

# In the TiFlash repository root:
mkdir cmake-build-debug  # The directory name can be customized
cd cmake-build-debug

cmake .. -GNinja -DCMAKE_BUILD_TYPE=DEBUG

ninja tiflash

error(cmake/tools.cmake:87):

Cannot find ar.

After excute

sudo pacman -S llvm

No error occurs again.

What problem does this PR solve?

Issue Number: close #6800
Problem Summary: Prepare Prerequisites on Arch Linux is not enough. We should add ' llvm ' .

What is changed and how it works?

Just append ' llvm ' in prepare commands on Arch Linux in README.md

Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

After I install arch linux and prepare according to the prompt of README.MD.
When I excute the commands follows , error occurs.
```
# In the TiFlash repository root:
mkdir cmake-build-debug  # The directory name can be customized
cd cmake-build-debug

cmake .. -GNinja -DCMAKE_BUILD_TYPE=DEBUG

ninja tiflash
```
error(cmake/tools.cmake:87):
```
Cannot find ar.
```
After excute
```
sudo pacman -S llvm
```
No error occurs again.
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Feb 12, 2023
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 12, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @xiaguan!

It looks like this is your first PR to pingcap/tiflash 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tiflash. 😃

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Feb 12, 2023
@Lloyd-Pottiger
Copy link
Contributor

Thanks for your contribution. But we have mention llvm in line59 - 61 🤔

@xiaguan
Copy link
Contributor Author

xiaguan commented Feb 12, 2023

I just read the 59-61 lines of readme.md. Is that the content of Ubuntu not Arch Linux ?

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-triage-completed labels Feb 13, 2023
@xiaguan
Copy link
Contributor Author

xiaguan commented Feb 13, 2023

/run-all-tests

@Lloyd-Pottiger Lloyd-Pottiger self-assigned this Feb 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@Lloyd-Pottiger
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 54956c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@ti-chi-bot ti-chi-bot merged commit e665e59 into pingcap:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Prerequisites on Arch Linux is not enough.
5 participants