Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support regexp_instr function #6272

Merged
merged 119 commits into from
Nov 28, 2022
Merged

Support regexp_instr function #6272

merged 119 commits into from
Nov 28, 2022

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Nov 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6115

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@xzhangxian1008
save
8c5768b
@xzhangxian1008
save
8b9c149
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
f4aeb00 
…y_pattern
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
c9922bc 
…y_pattern
@xzhangxian1008
ready to compile
c98b151
@xzhangxian1008
successfully compile
c126dc5
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
2eabd61 
…y_pattern
@xzhangxian1008
clean up
51ff173
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
74d7096 
…y_pattern
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
32879c2 
…y_pattern
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
1adc613 
…y_pattern
@xzhangxian1008
pass tests, for the moment
573f877
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
08f3305 
…y_pattern
@xzhangxian1008
pass gtests
101c4ff
@xzhangxian1008
ut passed
2be0ea7
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
7150b5f 
…y_pattern
@xzhangxian1008
format
61baf63
@xzhangxian1008
fix ut
74f090e
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
46a0499 
…y_pattern
@xzhangxian1008
save works
5f1d1f8
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
db38cf4 
…y_pattern
@xzhangxian1008
pass compilation
1de2747
@xzhangxian1008
format
fdade39
@xzhangxian1008
add the convertion of int col
9a03b7a
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
a6ede08 
…y_pattern
@xzhangxian1008
undef
c5e6672
@xzhangxian1008
save works
8f44a5d
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
291fcc8 
…y_pattern
@xzhangxian1008
tweaking
efb2d73
@xzhangxian1008
resolve
5a4b64a
windtalker
windtalker approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

tests/fullstack-test/expr/regexp.test Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2022
@SeaRise SeaRise self-requested a review November 23, 2022 05:55
SeaRise
SeaRise reviewed Nov 25, 2022
View reviewed changes
dbms/src/Common/UTF8Helpers.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsRegexp.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsRegexp.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsRegexp.h Outdated Show resolved Hide resolved
dbms/src/Common/OptimizedRegularExpression.inl.h Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor

SeaRise commented Nov 28, 2022

/run-all-tests

SeaRise
SeaRise reviewed Nov 28, 2022
View reviewed changes
dbms/src/Common/OptimizedRegularExpression.inl.h Outdated Show resolved Hide resolved
dbms/src/Common/OptimizedRegularExpression.inl.h Outdated Show resolved Hide resolved
dbms/src/Common/UTF8Helpers.h Outdated Show resolved Hide resolved
SeaRise
SeaRise approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 28, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Nov 28, 2022

/run-all-tests

@SeaRise
Copy link
Contributor

SeaRise commented Nov 28, 2022

/run-all-tests

ERROR 1139 (42000) at line 1: Got error 'Not support binary collation so far' from regexp

@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 29e6401

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2022
@ti-chi-bot
Copy link
Member

@xzhangxian1008: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

ERROR 1139 (42000) at line 1: Got error 'Not support binary collation so far' from regexp

resolved

@ti-chi-bot ti-chi-bot merged commit 23ec2e1 into pingcap:master Nov 28, 2022
@xzhangxian1008 xzhangxian1008 deleted the instr branch November 28, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi left review comments

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xzhangxian1008 @ti-chi-bot @SeaRise @windtalker @gengliqi