-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Introduce test framework similar to Segment Test for DMStore #5982
Conversation
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/merge |
@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 07bf54f
|
/run-unit-test |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
What problem does this PR solve?
Issue Number: ref #5237
What is changed and how it works?
A new test framework for DeltaMergeStore is introduced, in order to write tests for it easier. The usage is very similar to our Segment Test Framework, that mostly you only need to specify a Int64 PK for everything and you will get compatibility for both common handle and int handle.
Example usages: https://github.com/pingcap/tiflash/blob/62dd77770790df636c7168f6bf482e55ce603d58/dbms/src/Storages/DeltaMerge/tests/gtest_dm_store_background.cpp
Migrated the background test in the DeltaMergeStore into this new test framework.
Always enable release build for libsymbolization, because I found it takes too much time (as long as 10+s) to generate a stack trace when libsymbolization is compiled under debug profile. Note that the stack trace is used in the SyncPoint framework -- it always prints the stack trace for easier debugging.
Check List
Tests
Side effects
Documentation
Release note